Search

[markup] Unfuddle Markup for commit linking bugged

Subscribe to [markup] Unfuddle Markup for commit linking bugged 6 post(s)

 
Nathaniel

Using the [abc123] syntax for linking to commits in project and ticket comments appears to be subtly bugged. If, the [abc123] is at the end of the commit (no following punctuation or spaces), the text is not recognized as a commit link:

Check out [536ee7a354ba118e0caa67880bdbdabd0f901232]

If, however, the end of the comment is “[abc123].”, or followed by any other content, it works as advertised:

Check out [536ee7a354ba118e0caa67880bdbdabd0f901232].

I’m guessing this is a failure on the, possibly, regular expression matching for the Unfuddle Markup syntax: ignoring the final word of a string.

 
Joshua Frappier

Nathaniel,

Thanks for the heads up on this issue. We are actually aware of the problem and have a fix queued up for release. Things should be cleared up in a few weeks with one of our next big releases.

Thanks,

Josh

 
Evanlec

perhaps related to this, is there any way we could do abbreviated commit sha ’s ? like [536ee7] instead of the full string? would be a little easier on the eyes I think.
thanks for your time,

Evan

 
zoomzoom83

This appears to have completely stopped working again, None of my SHA-1 hashes in comments are linking to the changeset anymore.

 
Joshua Frappier

Please note that if the a repository is associated with more than one project, then the hash would be ambiguous and would not be converted into a link. You may want to start by verifying that the repository is only associated with a single project for this to work.

If it still does not work, please send us an email with a link to the comment in question and we will do our best to track down the source of the problem.

 
zoomzoom83

Arg, my bad. This was exactly it. thanks :-D

(n.b. I’m using Git, where the commit hashes are always going to be unique, even across multiple repositories. It should be fairly easy to be able to support this – could be quite a nice new feature)